Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): Fix missing % in calculation #4157

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

joeyparrish
Copy link
Member

This bug has always been there, as far as I can tell, since the ads UI
was added. This issue was caught by an internal compilation tool and
another project that consumes our UI.

This bug has always been there, as far as I can tell, since the ads UI
was added.  This issue was caught by an internal compilation tool and
another project that consumes our UI.
@joeyparrish joeyparrish merged commit 1c86195 into shaka-project:main Apr 26, 2022
@joeyparrish joeyparrish deleted the fix-missing-percentage branch April 26, 2022 04:46
joeyparrish added a commit that referenced this pull request Apr 26, 2022
This bug has always been there, as far as I can tell, since the ads UI
was added.  This issue was caught by an internal compilation tool and
another project that consumes our UI.
joeyparrish added a commit that referenced this pull request Apr 26, 2022
This bug has always been there, as far as I can tell, since the ads UI
was added.  This issue was caught by an internal compilation tool and
another project that consumes our UI.
joeyparrish added a commit that referenced this pull request Apr 26, 2022
This bug has always been there, as far as I can tell, since the ads UI
was added.  This issue was caught by an internal compilation tool and
another project that consumes our UI.
@avelad avelad added this to the v4.0 milestone May 4, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants